Working flow authorize

This commit is contained in:
2025-09-16 12:45:22 -04:00
parent 47e3fb443b
commit 630584512e
5 changed files with 132 additions and 61 deletions

View File

@@ -2,6 +2,7 @@ from fastapi import FastAPI
from .database import engine from .database import engine
from . import models from . import models
from .routers import payment from .routers import payment
from .routers.transaction import transaction_router
from fastapi.middleware.cors import CORSMiddleware from fastapi.middleware.cors import CORSMiddleware
from config import load_config from config import load_config
@@ -26,6 +27,7 @@ app.add_middleware(
app.include_router(payment.router, prefix="/api", tags=["payment"]) app.include_router(payment.router, prefix="/api", tags=["payment"])
app.include_router(transaction_router, prefix="/api", tags=["transactions"])

View File

@@ -55,14 +55,13 @@ class Transaction(Base):
# Recommended change: Use Numeric for precision # Recommended change: Use Numeric for precision
preauthorize_amount = Column(Numeric(10, 2), nullable=True) preauthorize_amount = Column(Numeric(10, 2), nullable=True)
charge_amount = Column(Numeric(10, 2), nullable=True) charge_amount = Column(Numeric(10, 2), nullable=True)
customer_id = Column(Integer)
transaction_type = Column(Integer) transaction_type = Column(Integer)
status = Column(Integer) status = Column(Integer)
auth_net_transaction_id = Column(String, unique=True, index=True, nullable=True) auth_net_transaction_id = Column(String, unique=True, index=True, nullable=True)
customer_id = Column(Integer, ForeignKey("customers.id"))
service_id = Column(Integer, nullable=True) service_id = Column(Integer, nullable=True)
delivery_id = Column(Integer, nullable=True) delivery_id = Column(Integer, nullable=True)
card_id = Column(Integer, ForeignKey("cards.id"), nullable=True) card_id = Column(Integer, nullable=True)
payment_gateway = Column(Integer, default=1) payment_gateway = Column(Integer, default=1)
rejection_reason = Column(String, nullable=True) rejection_reason = Column(String, nullable=True)
created_at = Column(DateTime, default=datetime.datetime.utcnow) created_at = Column(DateTime, default=datetime.datetime.utcnow)

View File

@@ -47,21 +47,53 @@ def _parse_authnet_response(response: Optional[AuthNetResponse]) -> Tuple[Transa
status = TransactionStatus.DECLINED status = TransactionStatus.DECLINED
auth_net_transaction_id = None auth_net_transaction_id = None
rejection_reason = "Payment declined by gateway." rejection_reason = "Payment declined by gateway."
print("DEBUG: Full response object")
print(response)
print("DEBUG: response.messages")
print(response.messages)
print("DEBUG: response.messages.resultCode")
print(response.messages.resultCode)
if response is not None: if response is not None:
if hasattr(response, 'transactionResponse') and response.transactionResponse and hasattr(response.transactionResponse, 'errors') and response.transactionResponse.errors: if hasattr(response, 'transactionResponse') and response.transactionResponse and hasattr(response.transactionResponse, 'errors') and response.transactionResponse.errors:
print("DEBUG: Using transactionResponse.errors")
error = response.transactionResponse.errors[0] error = response.transactionResponse.errors[0]
rejection_reason = f"{error.errorCode.text}: {error.errorText.text}" rejection_reason = f"{error.errorCode.text}: {error.errorText.text}"
elif hasattr(response, 'messages') and response.messages and hasattr(response.messages, 'message') and response.messages.message: elif hasattr(response, 'messages') and response.messages and hasattr(response.messages, 'message') and response.messages.message:
print("DEBUG: Using response.messages.message")
msg = response.messages.message[0] msg = response.messages.message[0]
rejection_reason = f"{msg.code.text}: {msg.text.text}" print("DEBUG: msg object")
print(msg)
print("DEBUG: msg attributes")
print(dir(msg))
print("DEBUG: msg.code")
print(getattr(msg, 'code', 'NO code ATTR'))
print("DEBUG: msg.text")
print(getattr(msg, 'text', 'NO text ATTR'))
code_val = None
text_val = None
if hasattr(msg, 'code') and msg.code is not None and hasattr(msg.code, 'text'):
code_val = msg.code.text
elif hasattr(msg, 'code'):
code_val = str(msg.code)
if hasattr(msg, 'text') and msg.text is not None and hasattr(msg.text, 'text'):
text_val = msg.text.text
elif hasattr(msg, 'text'):
text_val = str(msg.text)
rejection_reason = f"{code_val}: {text_val}" if code_val and text_val and text_val != "None" else f"{code_val}" if code_val else f"Error: {getattr(msg, 'text', 'Unknown error')}"
print("DEBUG: Constructed rejection_reason")
print(rejection_reason)
return status, auth_net_transaction_id, rejection_reason return status, auth_net_transaction_id, rejection_reason
@router.post("/customers/{customer_id}/cards", response_model=schemas.CustomerCardResponse, summary="Add a new payment card for a customer") @router.post("/customers/{customer_id}/cards", summary="Add a new payment card for a customer")
def add_card_to_customer(customer_id: int, card_info: schemas.CardCreate, db: Session = Depends(database.get_db)): def add_card_to_customer(customer_id: int, card_info: schemas.CardCreate, db: Session = Depends(database.get_db)):
""" """
Adds a new credit card to a customer. Adds a new credit card to a customer.
- If the customer doesn't have an Authorize.Net profile, it creates one. - If the customer doesn't have an Authorize.Net profile, it creates one.
- If they do, it adds a new payment method to their existing profile. - If they do, it adds a new payment method to their existing profile.
Returns the payment_profile_id from Authorize.Net.
""" """
db_customer = crud.get_customer(db, customer_id=customer_id) db_customer = crud.get_customer(db, customer_id=customer_id)
if not db_customer: if not db_customer:
@@ -87,32 +119,14 @@ def add_card_to_customer(customer_id: int, card_info: schemas.CardCreate, db: Se
card_info=card_info card_info=card_info
) )
# This creates the card in our local database # Return the payment_profile_id
new_card = crud.create_customer_card( return {"payment_profile_id": payment_profile_id}
db=db,
customer_id=customer_id,
card_info=card_info,
payment_profile_id=payment_profile_id
)
# ========= THIS IS THE FIX FOR THE FRONTEND =========
# 1. Convert the newly created card object into a Pydantic model, then a dictionary.
# Make sure your schemas.Card uses `user_id` to match your model.
response_data = schemas.Card.from_orm(new_card).model_dump()
# 2. Manually add the 'customer_state' field that the frontend needs.
response_data['customer_state'] = "MA"
# 3. Return the complete dictionary. FastAPI validates it against CustomerCardResponse
# and sends it to the frontend.
return response_data
except ValueError as e: except ValueError as e:
# This will catch errors from the payment service # This will catch errors from the payment service
raise HTTPException(status_code=400, detail=str(e)) raise HTTPException(status_code=400, detail=str(e))
except Exception as e: except Exception as e:
# This will catch any other unexpected errors, like from the database # This will catch any other unexpected errors, like from the database
logger.error(f"An unexpected error occurred: {e}")
raise HTTPException(status_code=500, detail="An internal server error occurred.") raise HTTPException(status_code=500, detail="An internal server error occurred.")
@router.post("/charge/saved-card/{customer_id}", response_model=schemas.Transaction, summary="Charge a customer using a saved card") @router.post("/charge/saved-card/{customer_id}", response_model=schemas.Transaction, summary="Charge a customer using a saved card")
@@ -120,7 +134,7 @@ def charge_saved_card(customer_id: int, transaction_req: schemas.TransactionCrea
db_customer = crud.get_customer(db, customer_id=customer_id) db_customer = crud.get_customer(db, customer_id=customer_id)
db_card = crud.get_card_by_id(db, card_id=transaction_req.card_id) db_card = crud.get_card_by_id(db, card_id=transaction_req.card_id)
if not db_customer or not db_card or db_card.customer_id != customer_id: if not db_customer or not db_card or db_card.user_id != customer_id:
raise HTTPException(status_code=404, detail="Customer or card not found for this account") raise HTTPException(status_code=404, detail="Customer or card not found for this account")
if not db_customer.auth_net_profile_id or not db_card.auth_net_payment_profile_id: if not db_customer.auth_net_profile_id or not db_card.auth_net_payment_profile_id:
@@ -190,25 +204,4 @@ def authorize_saved_card(customer_id: int, transaction_req: schemas.TransactionA
auth_net_transaction_id=auth_net_transaction_id auth_net_transaction_id=auth_net_transaction_id
) )
# --- YOUR EXISTING CAPTURE ENDPOINT NEEDS NO CHANGES --- # --- CAPTURE ENDPOINT MOVED TO TRANSACTION ROUTER ---
@router.post("/capture/", response_model=schemas.Transaction, summary="Capture a previously authorized amount")
def capture_authorized_amount(transaction: schemas.TransactionCapture, db: Session = Depends(database.get_db)):
# This endpoint continues to work perfectly.
# It finds the original transaction by its ID and captures the funds.
auth_transaction = crud.get_transaction_by_auth_id(db, auth_net_transaction_id=transaction.auth_net_transaction_id)
if not auth_transaction:
raise HTTPException(status_code=404, detail="Authorization transaction not found")
# ... The rest of your existing capture logic remains the same ...
auth_net_response = payment_service.capture_authorized_transaction(transaction)
status, _, rejection_reason = _parse_authnet_response(auth_net_response) # The capture response doesn't return a new ID
# Use your existing CRUD function to update the transaction
return crud.update_transaction_for_capture(
db=db,
auth_net_transaction_id=transaction.auth_net_transaction_id,
charge_amount=transaction.charge_amount,
status=status,
rejection_reason=rejection_reason
)

View File

@@ -0,0 +1,76 @@
## File: transaction.py (New transaction router)
from fastapi import APIRouter, Depends, HTTPException
from sqlalchemy.orm import Session
import enum
# Import locally to avoid circular imports
import sys
import os
sys.path.append(os.path.dirname(os.path.dirname(os.path.dirname(__file__))))
from app import crud, database, schemas
from app.services import payment_service
# Create a router for transaction endpoints
transaction_router = APIRouter()
class TransactionStatus(enum.IntEnum):
APPROVED = 0
DECLINED = 1
# Test endpoint to verify router is working
@transaction_router.get("/test/", summary="Test transaction router")
def test_transaction_router():
"""Test endpoint to verify transaction router is loaded"""
return {"test": "transaction router is working"}
@transaction_router.get("/transaction/delivery/{delivery_id}", summary="Get pre-authorization transaction for a delivery")
def get_delivery_transaction(delivery_id: int, db: Session = Depends(database.get_db)):
"""
Get the pre-authorization transaction for a specific delivery.
This endpoint is used to retrieve transaction details for delivery finalization.
"""
transaction = crud.get_transaction_by_delivery_id(db, delivery_id=delivery_id)
if not transaction:
raise HTTPException(status_code=404, detail="No pre-authorization transaction found for this delivery")
return {
"id": transaction.id,
"transaction_type": transaction.transaction_type,
"status": transaction.status,
"auth_net_transaction_id": transaction.auth_net_transaction_id,
"preauthorize_amount": transaction.preauthorize_amount
}
@transaction_router.post("/capture/", response_model=schemas.Transaction, summary="Capture a previously authorized amount")
def capture_authorized_amount(transaction: schemas.TransactionCapture, db: Session = Depends(database.get_db)):
# This endpoint captures a previously authorized transaction
# It finds the original transaction by its ID and captures the funds
auth_transaction = crud.get_transaction_by_auth_id(db, auth_net_transaction_id=transaction.auth_net_transaction_id)
if not auth_transaction:
raise HTTPException(status_code=404, detail="Authorization transaction not found")
# Call the capture service function
auth_net_response = payment_service.capture_authorized_transaction(transaction)
status, _, rejection_reason = _parse_authnet_response(auth_net_response)
# Use the existing CRUD function to update the transaction
return crud.update_transaction_for_capture(
db=db,
auth_net_transaction_id=transaction.auth_net_transaction_id,
charge_amount=transaction.charge_amount,
status=status,
rejection_reason=rejection_reason
)
def _parse_authnet_response(response):
"""
Parse Authorize.Net response for transaction status
"""
if response is not None and hasattr(response, 'messages') and response.messages.resultCode == "Ok":
status = TransactionStatus.APPROVED
rejection_reason = None
else:
status = TransactionStatus.DECLINED
rejection_reason = "Payment declined by gateway."
return status, None, rejection_reason

View File

@@ -106,7 +106,8 @@ def create_customer_profile(customer: schemas.Customer, card_info: schemas.CardC
paymentProfile = apicontractsv1.customerPaymentProfileType( paymentProfile = apicontractsv1.customerPaymentProfileType(
billTo=billTo, billTo=billTo,
payment=apicontractsv1.paymentType(creditCard=creditCard) payment=apicontractsv1.paymentType(creditCard=creditCard),
defaultPaymentProfile=True
) )
customerProfile = apicontractsv1.customerProfileType( customerProfile = apicontractsv1.customerProfileType(
@@ -187,7 +188,8 @@ def add_payment_profile_to_customer(customer_profile_id: str, customer: schemas.
paymentProfile = apicontractsv1.customerPaymentProfileType( paymentProfile = apicontractsv1.customerPaymentProfileType(
billTo=billTo, billTo=billTo,
payment=apicontractsv1.paymentType(creditCard=creditCard) payment=apicontractsv1.paymentType(creditCard=creditCard),
defaultPaymentProfile=True
) )
request = apicontractsv1.createCustomerPaymentProfileRequest( request = apicontractsv1.createCustomerPaymentProfileRequest(
@@ -230,10 +232,9 @@ def authorize_customer_profile(customer_profile_id: str, payment_profile_id: str
merchantAuth = apicontractsv1.merchantAuthenticationType(name=API_LOGIN_ID, transactionKey=TRANSACTION_KEY) merchantAuth = apicontractsv1.merchantAuthenticationType(name=API_LOGIN_ID, transactionKey=TRANSACTION_KEY)
profile_to_authorize = apicontractsv1.profileTransAuthOnlyType( profile_to_authorize = apicontractsv1.customerProfilePaymentType()
customerProfileId=customer_profile_id, profile_to_authorize.customerProfileId = customer_profile_id
paymentProfileId=payment_profile_id profile_to_authorize.customerPaymentProfileId = payment_profile_id
)
transactionRequest = apicontractsv1.transactionRequestType( transactionRequest = apicontractsv1.transactionRequestType(
transactionType="authOnlyTransaction", transactionType="authOnlyTransaction",