Major Refactor
This commit is contained in:
@@ -99,22 +99,24 @@ def create_user_card(user_id):
|
||||
"""
|
||||
adds a card of a user
|
||||
"""
|
||||
|
||||
get_customer = (db.session
|
||||
.query(Customer_Customer)
|
||||
.filter(Customer_Customer.id == user_id)
|
||||
.first())
|
||||
|
||||
name_on_card = request.json["card_name"]
|
||||
expiration_month = request.json["expiration_month"]
|
||||
expiration_year = request.json["expiration_year"]
|
||||
type_of_card = request.json["type_of_card"]
|
||||
security_number = request.json["security_number"]
|
||||
main_card = request.json["main_card"]
|
||||
zip_code = request.json["zip_code"]
|
||||
|
||||
card_number = request.json["card_number"]
|
||||
last_four = card_number[-4]
|
||||
|
||||
# --- FIX: Use .get() for safety and get the correct key 'name_on_card' ---
|
||||
data = request.get_json()
|
||||
name_on_card = data.get("name_on_card") # <-- CORRECT KEY
|
||||
expiration_month = data.get("expiration_month")
|
||||
expiration_year = data.get("expiration_year")
|
||||
type_of_card = data.get("type_of_card")
|
||||
security_number = data.get("security_number")
|
||||
main_card = data.get("main_card", False)
|
||||
zip_code = data.get("zip_code")
|
||||
card_number = data.get("card_number")
|
||||
|
||||
# --- FIX: Correctly slice the last four digits ---
|
||||
last_four = card_number[-4:] if card_number else ""
|
||||
|
||||
create_new_card = Card_Card(
|
||||
user_id=get_customer.id,
|
||||
@@ -131,12 +133,10 @@ def create_user_card(user_id):
|
||||
)
|
||||
db.session.add(create_new_card)
|
||||
db.session.flush()
|
||||
if main_card is True:
|
||||
try:
|
||||
set_card_main(user_id=get_customer.id, card_id=create_new_card.id)
|
||||
except:
|
||||
pass
|
||||
db.session.add(create_new_card)
|
||||
|
||||
if main_card:
|
||||
set_card_main(user_id=get_customer.id, card_id=create_new_card.id)
|
||||
|
||||
db.session.commit()
|
||||
|
||||
return jsonify({"ok": True}), 200
|
||||
@@ -176,28 +176,25 @@ def update_user_card(card_id):
|
||||
"""
|
||||
edits a card
|
||||
"""
|
||||
|
||||
get_card = (db.session
|
||||
.query(Card_Card)
|
||||
.filter(Card_Card.id == card_id)
|
||||
.first())
|
||||
|
||||
get_customer = (db.session
|
||||
.query(Customer_Customer)
|
||||
.filter(Customer_Customer.id == get_card.user_id)
|
||||
.first())
|
||||
if not get_card:
|
||||
return jsonify({"ok": False, "error": "Card not found"}), 404
|
||||
|
||||
# --- FIX: Use .get() for safety and get the correct key 'name_on_card' ---
|
||||
data = request.get_json()
|
||||
name_on_card = data.get("name_on_card") # <-- CORRECT KEY
|
||||
expiration_month = data.get("expiration_month")
|
||||
expiration_year = data.get("expiration_year")
|
||||
type_of_card = data.get("type_of_card")
|
||||
security_number = data.get("security_number")
|
||||
card_number = data.get("card_number")
|
||||
main_card = data.get("main_card", False)
|
||||
zip_code = data.get("zip_code")
|
||||
|
||||
name_on_card = request.json["card_name"]
|
||||
expiration_month = request.json["expiration_month"]
|
||||
expiration_year = request.json["expiration_year"]
|
||||
type_of_card = request.json["type_of_card"]
|
||||
security_number = request.json["security_number"]
|
||||
card_number = request.json["card_number"]
|
||||
main_card = request.json["main_card"]
|
||||
zip_code = request.json["zip_code"]
|
||||
|
||||
get_card.user_id = get_customer.id
|
||||
get_card.card_number = card_number
|
||||
get_card.name_on_card = name_on_card
|
||||
get_card.expiration_month = expiration_month
|
||||
@@ -206,9 +203,13 @@ def update_user_card(card_id):
|
||||
get_card.security_number = security_number
|
||||
get_card.main_card = main_card
|
||||
get_card.zip_code = zip_code
|
||||
|
||||
# --- FIX: Correctly slice the last four digits on edit ---
|
||||
if card_number:
|
||||
get_card.last_four_digits = card_number[-4:]
|
||||
|
||||
if main_card is True:
|
||||
set_card_main(user_id=get_customer.id, card_id=get_card.id)
|
||||
if main_card:
|
||||
set_card_main(user_id=get_card.user_id, card_id=get_card.id)
|
||||
|
||||
db.session.add(get_card)
|
||||
db.session.commit()
|
||||
|
||||
Reference in New Issue
Block a user